Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (carousel block): show inner column margins in frontend #3257

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix (carousel block): show inner column margins in frontend #3257

merged 3 commits into from
Sep 5, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Jul 22, 2024

fixes #3173

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

🤖 Pull request artifacts

file commit
pr3257-stackable-3257-merge.zip ee8900c

github-actions bot added a commit that referenced this pull request Jul 22, 2024
@github-actions
Upload pr3257-stackable-3257-merge.zip (6be73)
ba58bf4 
Pull request: #3257
Commit: 6be73bd
@github-actions GitHub Actions
Copy link

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3257-stackable-3257-merge.zip"}}]}

bfintal
bfintal reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a huge amount of changes that even adds to PHP overhead, just because the left/right margins are not showing in the frontend. Why are they not showing up in the first place?

github-actions bot added a commit that referenced this pull request Aug 9, 2024
@github-actions
Upload pr3257-stackable-3257-merge.zip (ee890)
3c7276f 
Pull request: #3257
Commit: ee8900c
@andeng1106
Copy link

@mxkae The fix didn't apply on my end. Is there any setting I need to apply to show the fix? 🤔

Screen.Recording.2024-08-15.at.3.mp4

@bfintal
Copy link
Contributor

bfintal commented Aug 15, 2024

@andeng1106 our fix is just to remove the ability to change the margins when inside columns since you can achieve the same results with containers

@bfintal bfintal merged commit 99e9d35 into develop Sep 5, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3173-carousel-inner-column-margin branch September 5, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfintal bfintal bfintal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel block inner column margin issue
3 participants
@mxkae @andeng1106 @bfintal